Plan stale wfctl DNS marker cleanup#42
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes stale wfctl-managed _workflow-dns-managed TXT marker records visible in Diff (as deletions) even when manage_unlisted=false, aligning plan output with the existing apply-time cleanup behavior.
Changes:
- Track whether the desired state includes a current workflow-managed marker, and when
manage_unlisted=falsereport any other workflow-managed markers in the zone as deletions duringDiff. - Add a regression test covering the “duplicate marker” scenario (e.g.,
gigbagg.rocks) where one marker is desired and another is stale.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/drivers/dns.go | Extends diffRecords to surface stale workflow-managed marker deletions when unlisted records are otherwise preserved. |
| internal/drivers/dns_test.go | Adds regression coverage ensuring Diff flags stale workflow marker records as deletions under manage_unlisted=false. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Context
A gocodealone-dns plan using v0.1.20 did not include gigbagg.rocks, so apply would not enter the stale-marker cleanup path for already-converged resources. This makes the cleanup visible in the plan and executable by apply.